linux-kernel - Re: [PATCH 1/3] net: use this_cpu_xxx replace percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jan 2012 17:10:18 +0800
From:	"Alex,Shi" <alex.shi@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	kaber@...sh.net, eric.dumazet@...il.com, cl@...two.org,
	tj@...nel.org, linux-kernel@...r.kernel.org, ying.huang@...el.com,
	tglx@...utronix.de, mingo@...hat.com, avi@...hat.com,
	akpm@...ux-foundation.org, a.p.zijlstra@...llo.nl,
	kvm@...r.kernel.org, jeremy@...source.com
Subject: Re: [PATCH 1/3] net: use this_cpu_xxx replace percpu_xxx funcs

On Wed, 2012-01-11 at 01:03 -0800, David Miller wrote:
> From: "Alex,Shi" <alex.shi@...el.com>
> Date: Wed, 11 Jan 2012 16:45:33 +0800
> 
> >> >>>> percpu_xxx funcs are duplicated with this_cpu_xxx funcs, so replace them
> >> >>>> for further code clean up.
> >> >>>>
> >> >>>> And in preempt safe scenario, __this_cpu_xxx funcs has a bit better
> >> >>>> performance since __this_cpu_xxx has no redundant preempt_disable()
> >> >>>>
> >> >>>> Signed-off-by: Alex Shi <alex.shi@...el.com>
> >> >>>> ---
> >> >>>>  net/netfilter/xt_TEE.c |   12 ++++++------
> >> >>>>  net/socket.c           |    4 ++--
> >> >>>>  2 files changed, 8 insertions(+), 8 deletions(-)
> >> >>>
> >> >>> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> >> >>>
> >> >>> Thanks !
> >> >>
> >> >> Anyone like to pick up this patch? or more comments for this? 
> >> > 
> >> > Kaber, David: 
> >> > I appreciate for your any comments on this. Could you like do me a
> >> > favor? 
> >> 
> >> No objections from me.
> > 
> > rend this patch for 3.2.0 kernel with Eric's Ack. 
> > 
> > David, do you have any concerns for this patch?  I will very appreciate
> > if it can met 3.3 open window. 
> 
> Please just submit it directly with the other this_cpu() patches:
> 
> Acked-by: David S. Miller <davem@...emloft.net>

Thanks a lot! :) 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/