| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Jan 2012 08:53:23 +0800 From: Richard Zhao <richard.zhao@...escale.com> To: Shawn Guo <shawn.guo@...aro.org> CC: Richard Zhao <richard.zhao@...aro.org>, <patches@...aro.org>, <vinod.koul@...el.com>, <linux-kernel@...r.kernel.org>, <eric.miao@...aro.org>, <kernel@...gutronix.de>, <dan.j.williams@...el.com>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 6/6] dma/imx-sdma: check whether event_id0 < 32 when set event_mask On Tue, Jan 10, 2012 at 11:38:39PM +0800, Shawn Guo wrote: > On Tue, Jan 10, 2012 at 10:29:42PM +0800, Richard Zhao wrote: > > On Tue, Jan 10, 2012 at 10:20:10PM +0800, Shawn Guo wrote: > > > On Tue, Jan 10, 2012 at 03:01:50PM +0800, Richard Zhao wrote: > > > > Signed-off-by: Richard Zhao <richard.zhao@...aro.org> > > > > --- > > > > > > I think it deserves a sensible commit message explaining why the patch > > > is needed. > > If event_id0 < 32, 1 << (sdmac->event_id0 - 32) is not zero. This meant to make you clear about the patch. I'll add it in commit message. > > > My point is you may explain the exact problem you are seeing without > this patch The kernel don't have event_id < 32 case yet. I found the bug when I review the code. > and how the patch helps here. In general, doing so would > win a warm feeling from reviewers much more easily than leaving the > commit message empty there. I understand your point that comment as much as possible. Thanks Richard > > -- > Regards, > Shawn > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists