linux-kernel - [Regression] Commit "tpm: Introduce function to poll for result of self test" breaks suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Jan 2012 00:22:07 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: [Regression] Commit "tpm: Introduce function to poll for result of self test" breaks suspend

Hi Stefan,

Unfortunately, the following commit from you:

commit 68d6e6713fcb2ea6278661aaaf5f1c9c821b3751
Author: Stefan Berger <stefanb@...ux.vnet.ibm.com>
Date:   Fri Nov 11 12:57:04 2011 -0500

    tpm: Introduce function to poll for result of self test
    
    This patch introduces a function that runs the TPM_ContinueSelfTest()
    function and then polls the TPM to check whether it finished the selftest
    and can receive new commands.
    
    Signed-off-by: Stefan Berger <stefanb@...ux.vnet.ibm.com>

broke suspend on my Toshiba Portege R500.  It causes the tpm driver to
return an error code from .suspend() on every attempt to suspend the system.

Revertig this commit on top of the current Linus' tree fixes the problem for me.

If necessary, I'll collect more information about this problem tomorrow.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/