linux-kernel - Re: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 15 Jan 2012 10:30:32 -0500
From:	Dave Jones <davej@...hat.com>
To:	Jason Dravet <dravet@...mail.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add

On Sun, Jan 15, 2012 at 09:16:13AM -0600, Jason Dravet wrote:
 > 
 > This patch makes it clear that the problem is in the BIOS of the computer and not the kernel.  This patch applies to kernel 3.2.1.
 >  
 > Reported-by: Greg White <pcguy11@...e.com>
 > Signed-off-by: Jason Dravet <dravet@...mail.com>
 > Tested-by: Greg White <pcguy11@...e.com>
 >  
 > --- dir.orig    2012-01-14 18:58:20.026745884 -0600
 > +++ dir.c    2012-01-14 19:52:33.011444581 -0600
 > @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
 >               (path == NULL) ? sd->s_name :
 >               strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
 >                      sd->s_name));
 > +        WARN(1, KERN_WARNING
 > +             "Your BIOS is broken.  Please contact your computer manufacturer.");
 >          kfree(path);
 >      }
 
That certainly isn't always the case. Incorrectly written drivers
have also taken this codepath before now.

	Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/