linux-kernel - Re: [PATCH] devfreq: exynos4_bus: Use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Mon, 16 Jan 2012 00:54:25 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	박경민 <kyungmin.park@...sung.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] devfreq: exynos4_bus: Use dev_get_drvdata at appropriate
 places

> Signed-off-by: Axel Lin <axel.lin@...il.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@...sung.com>

Looks good. I'll apply this one.

> ---
>  drivers/devfreq/exynos4_bus.c |   16 ++++------------
>  1 files changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> index cd563da..0b67537 100644
> --- a/drivers/devfreq/exynos4_bus.c
> +++ b/drivers/devfreq/exynos4_bus.c
> @@ -622,9 +622,7 @@ static int exynos4_bus_setvolt(struct busfreq_data *data, struct opp *opp,
>  static int exynos4_bus_target(struct device *dev, unsigned long *_freq)
>  {
>   int err = 0;
> - struct platform_device *pdev = container_of(dev, struct platform_device,
> -          dev);
> - struct busfreq_data *data = platform_get_drvdata(pdev);
> + struct busfreq_data *data = dev_get_drvdata(dev);
>   struct opp *opp = devfreq_recommended_opp(dev, _freq);
>   unsigned long old_freq = opp_get_freq(data->curr_opp);
>   unsigned long freq = opp_get_freq(opp);
> @@ -689,9 +687,7 @@ static int exynos4_get_busier_dmc(struct busfreq_data *data)
>  static int exynos4_bus_get_dev_status(struct device *dev,
>            struct devfreq_dev_status *stat)
>  {
> - struct platform_device *pdev = container_of(dev, struct platform_device,
> -          dev);
> - struct busfreq_data *data = platform_get_drvdata(pdev);
> + struct busfreq_data *data = dev_get_drvdata(dev);
>   int busier_dmc;
>   int cycles_x2 = 2; /* 2 x cycles */
>   void __iomem *addr;
> @@ -739,9 +735,7 @@ static int exynos4_bus_get_dev_status(struct device *dev,
>  
>  static void exynos4_bus_exit(struct device *dev)
>  {
> - struct platform_device *pdev = container_of(dev, struct platform_device,
> -          dev);
> - struct busfreq_data *data = platform_get_drvdata(pdev);
> + struct busfreq_data *data = dev_get_drvdata(dev);
>  
>   devfreq_unregister_opp_notifier(dev, data->devfreq);
>  }
> @@ -1087,9 +1081,7 @@ static __devexit int exynos4_busfreq_remove(struct platform_device *pdev)
>  
>  static int exynos4_busfreq_resume(struct device *dev)
>  {
> - struct platform_device *pdev = container_of(dev, struct platform_device,
> -          dev);
> - struct busfreq_data *data = platform_get_drvdata(pdev);
> + struct busfreq_data *data = dev_get_drvdata(dev);
>  
>   busfreq_mon_reset(data);
>   return 0;
> -- 
> 1.7.5.4
> 
> 


------- Original Message -------
Sender : Axel Lin<axel.lin@...il.com>
Date : 2012-01-14 17:56 (GMT+09:00)
Title : [PATCH] devfreq: exynos4_bus: Use dev_get_drvdata at appropriate places

Signed-off-by: Axel Lin 
---
drivers/devfreq/exynos4_bus.c |   16 ++++------------
1 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
index cd563da..0b67537 100644
--- a/drivers/devfreq/exynos4_bus.c
+++ b/drivers/devfreq/exynos4_bus.c
@@ -622,9 +622,7 @@ static int exynos4_bus_setvolt(struct busfreq_data *data, struct opp *opp,
static int exynos4_bus_target(struct device *dev, unsigned long *_freq)
{
int err = 0;
- struct platform_device *pdev = container_of(dev, struct platform_device,
-     dev);
- struct busfreq_data *data = platform_get_drvdata(pdev);
+ struct busfreq_data *data = dev_get_drvdata(dev);
struct opp *opp = devfreq_recommended_opp(dev, _freq);
unsigned long old_freq = opp_get_freq(data->curr_opp);
unsigned long freq = opp_get_freq(opp);
@@ -689,9 +687,7 @@ static int exynos4_get_busier_dmc(struct busfreq_data *data)
static int exynos4_bus_get_dev_status(struct device *dev,
      struct devfreq_dev_status *stat)
{
- struct platform_device *pdev = container_of(dev, struct platform_device,
-     dev);
- struct busfreq_data *data = platform_get_drvdata(pdev);
+ struct busfreq_data *data = dev_get_drvdata(dev);
int busier_dmc;
int cycles_x2 = 2; /* 2 x cycles */
void __iomem *addr;
@@ -739,9 +735,7 @@ static int exynos4_bus_get_dev_status(struct device *dev,

static void exynos4_bus_exit(struct device *dev)
{
- struct platform_device *pdev = container_of(dev, struct platform_device,
-     dev);
- struct busfreq_data *data = platform_get_drvdata(pdev);
+ struct busfreq_data *data = dev_get_drvdata(dev);

devfreq_unregister_opp_notifier(dev, data->devfreq);
}
@@ -1087,9 +1081,7 @@ static __devexit int exynos4_busfreq_remove(struct platform_device *pdev)

static int exynos4_busfreq_resume(struct device *dev)
{
- struct platform_device *pdev = container_of(dev, struct platform_device,
-     dev);
- struct busfreq_data *data = platform_get_drvdata(pdev);
+ struct busfreq_data *data = dev_get_drvdata(dev);

busfreq_mon_reset(data);
return 0;
-- 
1.7.5.4






 MyungJoo Ham (함명주)
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033