lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jan 2012 09:28:04 +0900 From: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> To: Ulrich Drepper <drepper@...il.com> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, pp-manager@....hitachi.co.jp Subject: Re: Typo transferred from Intel manual Hi Ulrich, (2012/01/14 7:24), Ulrich Drepper wrote: > The arch/x86/lib/x86-opcode-map.txt file contains the line > > af: SCAS/W/D/Q rAX,Xv > > > This is what the Intel manuals show, but it's not correct. The 'X' stands for > > Memory addressed by the DS:rSI register pair (for example, MOVS, CMPS, > OUTS, or LODS). > > > On the other hand 'Y' means (also see the ae byte entry for SCASB): > > Memory addressed by the ES:rDI register pair (for example, MOVS, CMPS, > INS, STOS, or SCAS). I see, thanks for reporting :) > Hence the following patch should be applied: Could you add a comment line above the fix in x86-opcode-map.txt? I just consider the case that someone may confuse the fix itself is typo. Thank you! > > > Signed-off-by: Ulrich Drepper <drepper@...il.com> > > diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt > index 5b83c51..c292885 100644 > --- a/arch/x86/lib/x86-opcode-map.txt > +++ b/arch/x86/lib/x86-opcode-map.txt > @@ -219,7 +219,7 @@ ab: STOS/W/D/Q Yv,rAX > ac: LODS/B AL,Xb > ad: LODS/W/D/Q rAX,Xv > ae: SCAS/B AL,Yb > -af: SCAS/W/D/Q rAX,Xv > +af: SCAS/W/D/Q rAX,Yv > # 0xb0 - 0xbf > b0: MOV AL/R8L,Ib > b1: MOV CL/R9L,Ib > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@...achi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists