linux-kernel - Re: [PATCH v4] ramoops: use pstore interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Jan 2012 15:55:52 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	Tony Luck <tony.luck@...el.com>,
	Marco Stornelli <marco.stornelli@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <greg@...ah.com>,
	Randy Dunlap <rdunlap@...otime.net>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ramoops: use pstore interface

On Tue, 17 Jan 2012 15:48:25 -0800
Kees Cook <keescook@...omium.org> wrote:

> > Note that pstore_get_records() will treat the -ve errno returns from
> > ->read() in the same manner as EOF.  IOW, your error codes will be
> > dropped on the floor.  This appears to be a bug in pstore_get_records().
> 
> Well, IIUC, it just means the file doesn't get populated at all; there
> is no userspace interface to finding out why a file didn't appear in
> the pstore fliesystem. But yes, the specifics of the error are ignored
> by pstore_get_records(). It didn't seem wrong to produce meaningful
> codes in ramoops, though.
> 

Well, there's a printk() in there.  But it only comes out if it was
pstore_mkfile() which failed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/