linux-kernel - Re: [PATCH v9 3.2 2/9] uprobes: handle breakpoint and signal step exception.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jan 2012 06:01:58 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	Anton Arapov <anton@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Linux-mm" <linux-mm@...ck.org>, Andi Kleen <andi@...stfloor.org>,
	Christoph Hellwig <hch@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Roland McGrath <roland@...k.frob.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v9 3.2 2/9] uprobes: handle breakpoint and signal step exception.

On Wednesday 18 January 2012 05:47:49 Srikar Dronamraju wrote:
> > On Wednesday 18 January 2012 04:02:32 Srikar Dronamraju wrote:
> > > >   Can we use existing SET_IP() instead of set_instruction_pointer() ?
> > > 
> > > Oleg had already commented about this in one his uprobes reviews.
> > > 
> > > The GET_IP/SET_IP available in include/asm-generic/ptrace.h doesnt work
> > > on all archs. Atleast it doesnt work on powerpc when I tried it.
> > 
> > so migrate the arches you need over to it.
> 
> One question that could be asked is why arent we using instruction_pointer
> instead of GET_IP since instruction_pointer is being defined in 25
> places and with references in 120 places.

i think you misunderstand the point.  {G,S}ET_IP() is the glue between the 
arch's pt_regs struct and the public facing API.  the only people who should 
be touching those macros are the ptrace core.  instruction_pointer() and 
instruction_pointer_set() are the API that asm/ptrace.h exports to the rest of 
the tree.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)