linux-kernel - Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Jan 2012 08:45:08 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Brice Goglin <Brice.Goglin@...ia.fr>
cc:	Greg Dietsche <Gregory.Dietsche@....edu>, julia.lawall@...6.fr,
	Michal Marek <mmarek@...e.cz>, mmarek@...e.cz,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set



On Sat, 21 Jan 2012, Brice Goglin wrote:

> Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back.
>
> Tested-by: Brice Goglin <Brice.Goglin@...ia.fr>
>
>
>
> Le 21/01/2012 00:10, Greg Dietsche a écrit :
>> This patch reverts a portion of d0bc1fb4 so that coccicheck will
>> work properly when C=1 or C=2.
>>
>> Reported-by: Brice Goglin <Brice.Goglin@...ia.fr>
>> Signed-off-by: Greg Dietsche <Gregory.Dietsche@....edu>

Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

>> ---
>>  scripts/coccicheck |   13 ++++---------
>>  1 files changed, 4 insertions(+), 9 deletions(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index 3c27764..823e972 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
>>  #    FLAGS="-ignore_unknown_options -very_quiet"
>>  #    OPTIONS=$*
>>
>> -    if [ "$KBUILD_EXTMOD" = "" ] ; then
>> -        # Workaround for Coccinelle < 0.2.3
>> -        FLAGS="-I $srctree/include -very_quiet"
>> -        shift $(( $# - 1 ))
>> -        OPTIONS=$1
>> -    else
>> -	echo M= is not currently supported when C=1 or C=2
>> -	exit 1
>> -    fi
>> +# Workaround for Coccinelle < 0.2.3
>> +	FLAGS="-I $srctree/include -very_quiet"
>> +	shift $(( $# - 1 ))
>> +	OPTIONS=$1
>>  else
>>      ONLINE=0
>>      FLAGS="-very_quiet"
>
>