| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jan 2012 15:04:07 -0500 From: Jeff Moyer <jmoyer@...hat.com> To: Niels de Vos <ndevos@...hat.com> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, "Bryn M. Reeves" <bmr@...hat.com>, Mikulas Patocka <mpatocka@...hat.com> Subject: Re: [PATCH v2] fs: Invalidate the cache for a parent block-device if fsync() is called for a partition Niels de Vos <ndevos@...hat.com> writes: > Executing an fsync() on a file-descriptor of a partition flushes the > caches for that partition by calling blkdev_issue_flush(). However, it > seems that reading data through the parent device will still return the > old cached data. You are mixing up two different caches. blkdev_issue_flush flushes the hard disk's cache, if it exists, and is advertised as a write-back cache. The cache that doesn't get flushed is the page cache, since you are accessing the same disk blocks via different devices (the whole device and the partition). Nevertheless, the fix looks fine to me. There shouldn't be much cached for the whole block device if there are partitions, so this shouldn't generate an I/O storm or flush out buffers that are otherwise useful. Reviewed-by: Jeff Moyer <jmoyer@...hat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists