linux-kernel - Re: [PATCH] regulator: Set apply_uV only when min and max voltages are defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jan 2012 11:22:58 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Karol Lewandowski <k.lewandowsk@...sung.com>
Cc:	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
	s.nawrocki@...sung.com, lrg@...com,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Thomas Abraham <thomas.abraham@...aro.org>
Subject: Re: [PATCH] regulator: Set apply_uV only when min and max voltages
 are defined

On Wed, Jan 25, 2012 at 11:15:12AM +0100, Karol Lewandowski wrote:
> On 25.01.2012 10:31, Karol Lewandowski wrote:

> >apply_uV is errornously set when regulator is instantiated from device
> >tree, even when it doesn't contain any voltage constraints.

> While this fixes obvious error I doubt that apply_uV should be set
> based on min max equality. It have required fix to fixed
> regulator[1]

No, I think this is fine.  The only reason the fixed voltage regulator
required anything was that it overloads the constraint voltage values to
specify the voltage which we probably shouldn't have done in the first
place.  If the device is can't change voltages specifying a voltage
range for changes is silly.

> as well for max8997[2].  It'll probably require fixes in other places too.

The big problem there seems like specifying voltages in the first place,
if we know what device it is we should already know what's going on.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/