linux-kernel - Re: [PATCH v2] proc: speedup /proc/stat handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jan 2012 01:26:35 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Glauber Costa <glommer@...allels.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Paul Tuner <pjt@...gle.com>
Subject: Re: [PATCH v2] proc:  speedup /proc/stat handling

Le mercredi 25 janvier 2012 à 09:18 +0900, KAMEZAWA Hiroyuki a écrit :

> BTW, what is the reason of this change ?
> 
> > -	unsigned size = 4096 * (1 + num_possible_cpus() / 32);
> > +	unsigned size = 1024 + 128 * num_possible_cpus();
> 
> I think size of buffer is affected by the number of online cpus.
> (Maybe 128 is enough but please add comment why 128 ?)
> 

There is no change, as 4096/32 is 128 bytes per cpu.

Only change is granularity is not any more 32 cpus, but one.

Of course, kmalloc() is going to roundup to next power of two anyway.

So real allocation is bigger, unless we switch to vmalloc() eventually.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/