linux-kernel - Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jan 2012 14:31:00 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Seungwon Jeon <tgih.jun@...sung.com>
Cc:	Saugata Das <saugata.das@...aro.org>, linux-mmc@...r.kernel.org,
	Chris Ball <cjb@...top.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device

>> >> +
>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>> >> +               struct mmc_queue_req *mq_rq)
>> >> +{
>> >> +       struct mmc_blk_data *md = mq->data;
>> >> +       struct mmc_card *card = md->queue.card;
>> >> +       int status, ret = -EIO, retry = 2;
Hi. Seungwon.
First Thansk for your reply.
There is one more my review comment.
I think that EIO of ret is not needed. there is no case to be skipped
if/ese condition in do while loop.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/