linux-kernel - Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Jan 2012 19:31:55 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Andrey Vagin <avagin@...nvz.org>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Glauber Costa <glommer@...allels.com>,
	Tejun Heo <tj@...nel.org>, Matt Helsley <matthltc@...ibm.com>,
	Pekka Enberg <penberg@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Alexey Dobriyan <adobriyan@...il.com>, Valdis.Kletnieks@...edu
Subject: Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v7

On Fri, Jan 27, 2012 at 10:24:03PM +0400, Cyrill Gorcunov wrote:
> Sure, I'll try to (btw, where I should send it to? And in which
> format novadays mans are written? In plain old troff or some
> human readable asciidocs?) And... should I post man page
> on LKML as well?

Manpages are written in troff with -man and you would add the ASCII output
of the manpage to the commit log and send the troff source at some
point to linux-man.

> 
> > 
> > As I understand it every time the kernel adds some new kind of state
> > this would need to be extended too? This would seem like a lot of work,
> > especially since you always need to synchronize kernel/user space.
> > How would the user space break if it doesn't know about some newly
> > added state?
> 
> Wait, maybe I should use kernel-doc here and put comments with example
> right on top of SYSCALL definition?

The basic problem is if this interface is at the right level of abstraction.
I have some doubts on that. It seems like a long term maintenance nightmare to 
me.  It may be better to put the loop that would call this into the kernel.

> > > +#ifdef CONFIG_SYSVIPC
> > > +		ret = kcmp_ptr((long)task1->sysvsem.undo_list,
> > > +			       (long)task2->sysvsem.undo_list,
> > > +			       KCMP_SYSVSEM);
> > 
> > I assume that's normally NULL.
> > 
> 
> Hmm.. Andi, I seem not following. And?

It just doesn't seem like a very useful thing to compare.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/