linux-kernel - Re: [PATCH 3/5] TTY: use tty_standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Feb 2012 10:52:35 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	gregkh@...e.de, linux-kernel@...r.kernel.org, alan@...ux.intel.com
Subject: Re: [PATCH 3/5] TTY: use tty_standard_install

On 02/01/2012 10:40 AM, Jiri Slaby wrote:
> On 01/30/2012 09:14 PM, Jiri Slaby wrote:
>> Use the helper in the rest of the tty drivers. This is a simple
>> replacement.
>>
>> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
>> Cc: Greg Kroah-Hartman <gregkh@...e.de>
>> Cc: Alan Cox <alan@...ux.intel.com>
>> ---
>>  drivers/isdn/capi/capi.c     |    9 +++------
>>  drivers/misc/pti.c           |    6 +-----
>>  drivers/mmc/card/sdio_uart.c |    9 +++------
>>  drivers/tty/nozomi.c         |    8 ++------
>>  4 files changed, 9 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
>> index e44933d..ca9261a 100644
>> --- a/drivers/isdn/capi/capi.c
>> +++ b/drivers/isdn/capi/capi.c
>> @@ -1015,14 +1015,11 @@ capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty)
>>  {
>>  	int idx = tty->index;
>>  	struct capiminor *mp = capiminor_get(idx);
>> -	int ret = tty_init_termios(tty);
>> +	int ret = tty_standard_install(tty);
> 
> Uh, what version of the patch did I send? tty_standard_install takes 2
> arguments! I will post the correct one in a moment.

If my ISP's smtp server actually worked now. The patch is attached,
hopefully my mailer won't screw it.

thanks,
-- 
js

View attachment "0003-TTY-use-tty_standard_install.patch" of type "text/x-patch" (3140 bytes)