linux-kernel - Re: [PATCH] Re: linux-next: Tree for Feb 2 (media/radio/wl128x)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Feb 2012 12:20:25 -0600
From:	Manjunatha Halli <x0130808@...com>
To:	Randy Dunlap <rdunlap@...otime.net>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	<linux-next@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	Manjunatha Halli <manjunatha_halli@...com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>
Subject: Re: [PATCH] Re: linux-next: Tree for Feb 2 (media/radio/wl128x)

On 02/02/2012 12:40 PM, Randy Dunlap wrote:
> On 02/02/2012 09:20 AM, Manjunatha Halli wrote:
>> Hi Randy Dunlap,
>>
>> In config file you are missing the CONFIG_TI_ST config which builds the TI's shared transport driver upon which the FM driver works.
>>
>> Please select this config in drivers/misc/ti-st/Kconfig which will solve the problem.
> Wrong answer.
>
> The problem seems to be that GPIOLIB is not enabled, but wl128x Kconfig says:
>
> config RADIO_WL128X
> 	tristate "Texas Instruments WL128x FM Radio"
> 	depends on VIDEO_V4L2&&  RFKILL
> 	select TI_ST if NET&&  GPIOLIB
>
> so TI_ST is not selected here.
>
> The Kconfig files should handle this properly.
>
> Here is one possible fix for you to consider.
>
> ---
> From: Randy Dunlap<rdunlap@...otime.net>
>
> Fix build errors when GPIOLIB is not enabled.
> Fix wl128x Kconfig to depend on GPIOLIB since TI_ST also
> depends on GPIOLIB.
>
> (.text+0xe6d60): undefined reference to `st_register'
> (.text+0xe7016): undefined reference to `st_unregister'
> (.text+0xe70ce): undefined reference to `st_unregister'
>
> Signed-off-by: Randy Dunlap<rdunlap@...otime.net>
> Cc: Manjunatha Halli<manjunatha_halli@...com>
> ---
>   drivers/media/radio/wl128x/Kconfig |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20120202.orig/drivers/media/radio/wl128x/Kconfig
> +++ linux-next-20120202/drivers/media/radio/wl128x/Kconfig
> @@ -4,8 +4,8 @@
>   menu "Texas Instruments WL128x FM driver (ST based)"
>   config RADIO_WL128X
>   	tristate "Texas Instruments WL128x FM Radio"
> -	depends on VIDEO_V4L2&&  RFKILL
> -	select TI_ST if NET&&  GPIOLIB
> +	depends on VIDEO_V4L2&&  RFKILL&&  GPIOLIB
> +	select TI_ST if NET
>   	help
>   	Choose Y here if you have this FM radio chip.
>
>
>> Regards
>> Manju
>>
>> On 02/02/2012 12:07 PM, Randy Dunlap wrote:
>>> On 02/01/2012 07:45 PM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20120201:
>>> drivers/built-in.o: In function `fmc_prepare':
>>> (.text+0xe6d60): undefined reference to `st_register'
>>> drivers/built-in.o: In function `fmc_prepare':
>>> (.text+0xe7016): undefined reference to `st_unregister'
>>> drivers/built-in.o: In function `fmc_release':
>>> (.text+0xe70ce): undefined reference to `st_unregister'
>>>
>>>
>>> Full randconfig file is attached.
>

This solutions seems fine for me...

My only concern is since TI_ST is already have GPIOLIB in its dependency 
list is it OK to have the same thing in FM driver also?.

Manju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/