linux-kernel - Re: [PATCH V2] gpio: tps65910: Add sleep control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Feb 2012 17:15:08 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Laxman Dewangan <ldewangan@...dia.com>,
	linus.walleij@...ricsson.com, jedu@...mlogic.co.uk,
	lrg@...mlogic.co.uk, broonie@...nsource.wolfsonmicro.com,
	sameo@...ux.intel.com, gg@...mlogic.co.uk,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH V2] gpio: tps65910: Add sleep control support

On Wed, Feb 01, 2012 at 01:30:54PM +0100, Linus Walleij wrote:
> On Wed, Feb 1, 2012 at 7:39 AM, Laxman Dewangan <ldewangan@...dia.com> wrote:
> 
> > The device tps65910/tps65911 supports the sleep
> > functionality in some of gpios. If gpio is configured
> > in output mode and sleep is enabled then during device
> > sleep state, the output of gpio becomes LOW regardless
> > of non-sleep output value.
> > Such gpio can be used to control regulator switch such
> > that output of regulator is off in device sleep state.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> > ---
> > Changes from V1:
> > Taken care of review comments from Linus Walleij's
> > - Remove magic numbers and added macro for defining them.
> > - Used bool type for the platform's gpio sleep control data.
> 
> Thanks, looks good!
> Acked-by: Linus Walleij <linus.walleij@...aro.org>

Applied, thanks.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/