linux-kernel - Re: [PATCH] PM/Suspend: Avoid code duplication in suspend statistics update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Feb 2012 07:20:37 +0530
From:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
To:	Marcos Paulo de Souza <marcos.mage@...il.com>
CC:	len.brown@...el.com, pavel@....cz, rjw@...k.pl,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM/Suspend: Avoid code duplication in suspend statistics
 update

On 02/02/2012 07:09 AM, Marcos Paulo de Souza wrote:

> The code
>        if (error) {
>                suspend_stats.fail++;
>                dpm_save_failed_errno(error);
>        } else
>                suspend_stats.success++;
> 
> Appears in the kernel/power/main.c and kernel/power/suspend.c.
> 
> This patch just creates a new function to avoid duplicated code.
> 
> Suggested-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@...il.com>
> ---


Looks good to me :-)

Acked-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/