linux-kernel - Re: [PATCH] MCE, AMD: Select SMP explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Feb 2012 21:24:28 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Nick Bowler <nbowler@...iptictech.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH] MCE, AMD: Select SMP explicitly

On Thu, Feb 02, 2012 at 02:37:02PM -0500, Nick Bowler wrote:
> Hi,
> 
> On 2012-02-02 20:10 +0100, Borislav Petkov wrote:
> > Randy Dunlap reported that building randconfigs which do not select
> > CONFIG_SMP cause the following link error:
> > 
> > mce_amd.c:(.cpuinit.text+0x4723): undefined reference to `cpu_llc_shared_map'
> > 
> > Fix it.
> > 
> > Acked-by: Randy Dunlap <rdunlap@...otime.net>
> > Link: http://lkml.kernel.org/r/4F298A6C.6010101@xenotime.net
> > Signed-off-by: Borislav Petkov <bp@...en8.de>
> [...]
> >  config X86_MCE_AMD
> >  	def_bool y
> >  	prompt "AMD MCE features"
> > -	depends on X86_MCE && X86_LOCAL_APIC
> > +	depends on X86_MCE && X86_LOCAL_APIC && SMP
> 
> Is this feature truly irrelevant on UP systems?  I ask because I've
> always enabled this option on my UP AMD systems in the past...

No, you're right. Thanks for the suggestion. Scratch that version, I'll
think of a better fix.

Thanks.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/