| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 02 Feb 2012 13:32:07 -0800 From: Joe Perches <joe@...ches.com> To: Josh Triplett <josh@...htriplett.org> Cc: linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> Subject: Re: [PATCH] checkpatch: Check for quoted strings broken across lines On Thu, 2012-02-02 at 13:28 -0800, Josh Triplett wrote: > On Thu, Feb 02, 2012 at 12:36:29PM -0800, Joe Perches wrote: > > On Thu, 2012-02-02 at 12:06 -0800, Josh Triplett wrote: > > > Documentation/CodingStyle recommends not splitting quoted strings across > > > lines, because it breaks the ability to grep for the string. checkpatch > > > already makes an exception to the 80-column rule for quoted strings to > > > allow this. Rather than just allowing it, actively warn about quoted > > > strings split across lines. [] > > Seems sensible but there are also asm uses like: > > arch/x86/include/asm/pvclock.h: "xor %5,%5 ; " > > "add %4,%%eax ; " > I did see those, yes. However, a quick grep through the kernel shows > that those occur quite rarely compared to \n or \n\t; the latter looks > like the standard style. How about I provide a patch for > Documentation/CodingStyle adding a chapter on inline assembly, with that > and other style guidelines? :) Sounds fine to me. Another option might be to ignore all strings in any asm block. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists