[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 02 Feb 2012 16:38:02 -0500 (EST)
From: Nicolas Pitre <nico@...xnic.net>
To: Russell King - ARM Linux <linux@....linux.org.uk>
Cc: Stephen Boyd <sboyd@...eaurora.org>,
linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH] ARM: cache-v7: Disable preemption when reading CCSIDR
On Thu, 2 Feb 2012, Russell King - ARM Linux wrote:
> On Thu, Feb 02, 2012 at 11:24:46AM -0800, Stephen Boyd wrote:
> > Should we move get_thread_info into assembler.h? It seems odd
> > to include entry-header.S but I saw that vfp was doing the same.
>
> Probably yes, and probably also have preempt_disable and preempt_enable
> assembler macros. That's going to get rather icky if we have to
> explicitly call the scheduler though (to solve (1)).
What about a pair of helpers written in C instead?
v7_flush_dcache_all() could be renamed, and a wrapper function called
v7_flush_dcache_all() would call the preemption disable helper, call the
former v7_flush_dcache_all code, then call the preemption enable helper.
Then __v7_setup() could still call the core cache flush code without
issues.
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists