linux-kernel - Re: [PATCH][Trivial] Fix up version number reference in include/trace/events/power.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 04 Feb 2012 10:15:12 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	Jiri Kosina <jkosina@...e.cz>, Jesper Juhl <jj@...osbits.net>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH][Trivial] Fix up version number reference in
 include/trace/events/power.h

On Fri, 2012-02-03 at 13:51 -0800, Arjan van de Ven wrote:
> On 2/3/2012 1:42 PM, Jiri Kosina wrote:
> > On Sun, 15 Jan 2012, Jesper Juhl wrote:
> > 
> >>>> -/* This code will be removed after deprecation time exceeded (2.6.41) */
> >>>> +/* This code will be removed after deprecation time exceeded (3.1) */
> >>>
> >>> Shouldn't the real fix be to remove this code? What's the use of
> >>> changing the version number that this code will be removed from, when
> >>> the change won't get in until after the version that this code should
> >>> have been removed?
> >>>
> >>> This is like updating 2014 calendars to say the world will end in 2012.
> >>>
> >> Heh, yeah, in a way you are right. But we have lots of code in the kernel 
> >> that says it will be removed at <some date in the past>, so I just figured 
> >> that if this code ends up hanging around it should at least display the 
> >> correct version number for when it /should/ have been removed.
> >> The actual removal I'll leave up to others.
> > 
> > Funny thing. Okay, this doesn't seem to be in linux-next, so I am taking 
> > it.
> > 
> > Steven, planning to drop the code in a near future? :)
> 
> we shouldn't be dropping these yet.. tools are still using them.
> and there really is no cost to keeping them either.

Then the correct fix is to remove the comment, as it is incorrect.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/