lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 03 Feb 2012 17:33:46 -0800 From: Joe Perches <joe@...ches.com> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Andy Whitcroft <apw@...dowen.org>, Ingo Molnar <mingo@...e.hu>, Andrew Morton <akpm@...ux-foundation.org>, Cyrill Gorcunov <gorcunov@...nvz.org>, linux-kernel@...r.kernel.org, Pavel Emelyanov <xemul@...allels.com>, Serge Hallyn <serge.hallyn@...onical.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, Kees Cook <keescook@...omium.org>, Tejun Heo <tj@...nel.org>, Andrew Vagin <avagin@...nvz.org>, "Eric W. Biederman" <ebiederm@...ssion.com>, Alexey Dobriyan <adobriyan@...il.com>, Andi Kleen <andi@...stfloor.org>, KOSAKI Motohiro <kosaki.motohiro@...il.com>, "H. Peter Anvin" <hpa@...or.com>, Thomas Gleixner <tglx@...utronix.de>, Glauber Costa <glommer@...allels.com>, Matt Helsley <matthltc@...ibm.com>, Pekka Enberg <penberg@...nel.org>, Eric Dumazet <eric.dumazet@...il.com>, Vasiliy Kulikov <segoon@...nwall.com>, Valdis.Kletnieks@...edu Subject: Re: [PATCH] checkpatch: Warn on code with 6+ tab indentation On Fri, 2012-02-03 at 17:27 -0800, Linus Torvalds wrote: > On Fri, Feb 3, 2012 at 3:20 PM, Joe Perches <joe@...ches.com> wrote: > > Overly indented code should be refactored. > > Suggest refactoring excessive indentation of > > of if/else/for/do/while/switch statements. > I hate this patch. You liked the same premise, but a worse implementation, a couple years ago. https://lkml.org/lkml/2009/12/18/289 > Why? Because mindless checks like this would just lead to people > making things worse and intermixing spaces there instead. Can't happen. They'll get a different warning about mixing tabs and spaces or starting a line with spaces only. > Don't warn about things that will just result in people working around > the warnings with worse code! It merely suggests refactoring. ie: better code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists