linux-kernel - Re: [PATCH 1/2] dmaengine: intel_mid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Feb 2012 13:51:23 +0200
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	Dan Williams <dan.j.williams@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dmaengine: intel_mid_dma: fix error status mask

On 06/02/12 13:39, Vinod Koul wrote:
> On Tue, 2012-01-31 at 12:48 +0200, Adrian Hunter wrote:
>> The error status mask (MASK_ERR) has the same format as the other
>> masks (MASK_TFR, MASK_BLOCK etc) and must be cleared the same way.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
>> ---
>>  drivers/dma/intel_mid_dma.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
>> index 74f70aa..512e2ab 100644
>> --- a/drivers/dma/intel_mid_dma.c
>> +++ b/drivers/dma/intel_mid_dma.c
>> @@ -1056,7 +1056,8 @@ static irqreturn_t intel_mid_dma_interrupt(int irq, void *data)
>>  	}
>>  	err_status &= mid->intr_mask;
>>  	if (err_status) {
>> -		iowrite32(MASK_INTR_REG(err_status), mid->dma_base + MASK_ERR);
>> +		iowrite32((err_status << INT_MASK_WE),
>> +			  mid->dma_base + MASK_ERR);
> why not use the macro?

The parameter to the macro MASK_INTR_REG is the channel number.
err_status is not a channel number.

This is the same as the way it is done for MASK_TFR a few lines up.

>>  		call_tasklet = 1;
>>  	}
>>  	if (call_tasklet)
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/