linux-kernel - RE: [PATCH 1/1][resend] check for pci bar restore completion and retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Feb 2012 19:49:48 +0000
From:	"Kay, Allen M" <allen.m.kay@...el.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	"linux-pci-owner@...r.kernel.org" <linux-pci-owner@...r.kernel.org>,
	"Barnes, Jesse" <jesse.barnes@...el.com>,
	"Wilcox, Matthew R" <matthew.r.wilcox@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jean.guyader@...citrix.com" <jean.guyader@...citrix.com>,
	"eric.chanudet@...rix.com" <eric.chanudet@...rix.com>
Subject: RE: [PATCH 1/1][resend]  check for pci bar restore completion and
 retry

Sorry Jesse, I did not see this until now.  There is some problem with my email I was not aware of - many emails did not go into my inbox.

Given there are many reset methods, checking for actual BAR restore is more reliable and less testing for a various reset methods.  We can potentially add checks for completion in pcie_flr() since that's easy to do.

Eric/Jean, do you have other comments? 

Allen

-----Original Message-----
From: Jesse Barnes [mailto:jbarnes@...tuousgeek.org] 
Sent: Friday, January 27, 2012 11:44 AM
To: Kay, Allen M
Cc: linux-pci-owner@...r.kernel.org; Barnes, Jesse; Wilcox, Matthew R; linux-kernel@...r.kernel.org; jean.guyader@...citrix.com; eric.chanudet@...rix.com
Subject: Re: [PATCH 1/1][resend] check for pci bar restore completion and retry

On Thu, 26 Jan 2012 10:25:53 -0800
"Kay, Allen M" <allen.m.kay@...el.com> wrote:

> On some OEM systems, pci_restore_state() is called while FLR has not 
> yet completed.  As a result, PCI BAR register restore is not 
> successful.  This fix reads back the restored value and compares it 
> with saved value and re-tries 10 times before giving up.

Applied, but I don't think I got an answer as to why we don't do this delay/check when we perform the FLR in the first place?

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/