linux-kernel - Re: Hmm.. WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Feb 2012 07:10:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	David Ahern <dsahern@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	x86@...nel.org
Subject: Re: Hmm.. WARN_ON_ONCE(cpuc->enabled)


* David Ahern <dsahern@...il.com> wrote:

> On 02/09/2012 04:46 PM, Linus Torvalds wrote:
> > Ok, so I get the appended on my Core i5 when I did a "perf record -f
> > -e cycles:pp make -j" on the kernel build.
> > 
> > What's up, guys? I haven't tried that particular perf run in a while,
> > so it might have been going on for quite some time.
> 
> Perhaps already fixed by
> https://lkml.org/lkml/2012/2/4/42
> 
> It's not in your tree; but in tip/urgent.

That patch only fixed the symptom - there was an underlying bug 
that is fixed in perf/urgent as well, via:

  f39d47ff819e: perf: Fix double start/stop in x86_pmu_start()

I committed it two days ago - so it narrowly missed -rc3. Note 
that no actual misbehavior is known to be caused by this bug, 
beyond the annoying WARN_ONCE() messages and a potential slight 
mis-measurement.

I'll send those fixes to Linus in a couple of hours.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/