linux-kernel - Re: [PATCH] bcm: move DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Feb 2012 10:41:15 -0500
From:	Kevin McKinney <klmckinney1@...il.com>
To:	Danny Kukawka <danny.kukawka@...ect.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, Danny Kukawka <dkukawka@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcm: move DRIVER_HALT into enum LedEvents

Hi Danny,

On Tue, Feb 14, 2012 at 9:48 AM, Danny Kukawka <danny.kukawka@...ect.de> wrote:
> Move DRIVER_HALT into enum LedEvents to fix:
> drivers/staging/bcm/led_control.c: In function ‘LEDControlThread’:
> drivers/staging/bcm/led_control.c:817:3: warning: case value ‘255’
>  not in enumerated type ‘LedEventInfo_t’ [-Wswitch]
>
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>
> ---
>  drivers/staging/bcm/led_control.h |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/bcm/led_control.h b/drivers/staging/bcm/led_control.h
> index 0711ac2..57c8c45 100644
> --- a/drivers/staging/bcm/led_control.h
> +++ b/drivers/staging/bcm/led_control.h
> @@ -63,12 +63,10 @@ typedef enum LedEvents {
>        IDLEMODE_CONTINUE = 0x40,
>        IDLEMODE_EXIT = 0x80,
>        LED_THREAD_INACTIVE = 0x100,  //Makes the LED thread Inactivce. It wil be equivallent to putting the thread on hold.
> -       LED_THREAD_ACTIVE = 0x200    //Makes the LED Thread Active back.
> +       LED_THREAD_ACTIVE = 0x200,    /*Makes the LED Thread Active back*/
> +       DRIVER_HALT = 0xff
>  } LedEventInfo_t;                      /*Enumerated values of different driver states*/
>
> -#define DRIVER_HALT 0xff
> -
> -
A patch to fix this issue has already been submitted and applied.

Thanks,
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/