linux-kernel - Re: [PATCH] char random: fix boot id uniqueness race (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Feb 2012 19:50:47 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	Theodore Ts'o <tytso@....edu>, Matt Mackall <mpm@...enic.com>,
	Greg Kroah-Hartman <greg@...ah.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char random: fix boot id uniqueness race (v3)

Le mercredi 15 février 2012 à 13:40 -0500, Mathieu Desnoyers a écrit :
> The proc file /proc/sys/kernel/random/boot_id can be read concurrently
> by user-space processes. If two (or more) user-space processes
> concurrently read boot_id when sysctl_bootid is not yet assigned, a race
> can occur making boot_id differ between the reads. Because the whole
> point of the boot id is to be unique across a kernel execution, fix this
> by protecting this operation with a spinlock.
> 
> Given that this operation is not frequently used, hitting the spinlock
> on each call should not be an issue.
> 
> * Changelog since v1:
> - boot_id_mutex is now declared within the proc_do_uuid scope.
> - added explanation for memory barriers.
> 
> * Changelog since v2:
> - simplify: use spinlock on all paths, suggested by Eric Dumazet.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> CC: "Theodore Ts'o" <tytso@....edu>
> CC: Matt Mackall <mpm@...enic.com>
> CC: Eric Dumazet <eric.dumazet@...il.com>
> CC: Greg Kroah-Hartman <greg@...ah.com>
> ---
>  drivers/char/random.c |   11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> Index: linux-2.6-lttng/drivers/char/random.c
> ===================================================================
> --- linux-2.6-lttng.orig/drivers/char/random.c
> +++ linux-2.6-lttng/drivers/char/random.c
> @@ -1250,10 +1250,15 @@ static int proc_do_uuid(ctl_table *table
>  	uuid = table->data;
>  	if (!uuid) {
>  		uuid = tmp_uuid;
> -		uuid[8] = 0;
> -	}
> -	if (uuid[8] == 0)
>  		generate_random_uuid(uuid);
> +	} else {
> +		static DEFINE_SPINLOCK(bootid_spinlock);
> +
> +		spin_lock(&bootid_spinlock);
> +		if (!uuid[8])
> +			generate_random_uuid(uuid);
> +		spin_unlock(&bootid_spinlock);
> +	}
>  
>  	sprintf(buf, "%pU", uuid);
>  
> 

Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks Mathieu !


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/