linux-kernel - Re: [PATCH 1/2] ARM: remove memmove from boot/compressed/string.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Feb 2012 16:09:33 +0100
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Cc:	linux@....linux.org.uk, nicolas.pitre@...aro.org, tony@...mide.com,
	s.hauer@...gutronix.de, magnus.damm@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: remove memmove from boot/compressed/string.c

On 15:54 Thu 16 Feb     , Michael Opdenacker wrote:
> This patch removes the memmove function from boot/compressed/string.c
> - This definition conflicts with the one in lib/decompress_unxz.c
>   This change is required to support xz compression on ARM.
> - memmove is not used in any of the other decompressors
>   in lib/decompress_*.c
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> ---
>  arch/arm/boot/compressed/string.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/compressed/string.c b/arch/arm/boot/compressed/string.c
> index 36e53ef..369443a 100644
> --- a/arch/arm/boot/compressed/string.c
> +++ b/arch/arm/boot/compressed/string.c
> @@ -40,6 +40,7 @@ void *memcpy(void *__dest, __const void *__src, size_t __n)
>  	return __dest;
>  }
>  
> +/*
>  void *memmove(void *__dest, __const void *__src, size_t count)
>  {
>  	unsigned char *d = __dest;
> @@ -55,6 +56,7 @@ void *memmove(void *__dest, __const void *__src, size_t count)
>  		d[count] = s[count];
>  	return __dest;
>  }
> +*/
so why not drop it cleanly

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/