linux-kernel - Re: [PATCH 3/5] x86: s/#if CONFIG/#ifdef CONFIG/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Feb 2012 09:25:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH 3/5] x86: s/#if CONFIG/#ifdef CONFIG/


* Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: "H. Peter Anvin" <hpa@...or.com>"
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: x86@...nel.org
> ---
>  arch/x86/boot/compressed/head_32.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
> index a055993..a37b117 100644
> --- a/arch/x86/boot/compressed/head_32.S
> +++ b/arch/x86/boot/compressed/head_32.S
> @@ -173,7 +173,7 @@ relocated:
>  	call	decompress_kernel
>  	addl	$20, %esp
>  
> -#if CONFIG_RELOCATABLE
> +#ifdef CONFIG_RELOCATABLE
>  /*
>   * Find the address of the relocations.
>   */

I'd really prefer to read an actual "this is safe, because this 
value is defined in the Kconfig as ..." type of commit log 
instead of nothing, which would ensure us that you didnt just do 
a (fundamentally unsafe) sed job over the kernel tree but 
actually have *read* the Kconfig entries in question to ensure 
the correctness of your patches...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/