linux-kernel - Re: [PATCH v3 05/10] ARM: tegra: rework Tegra secondary CPU core bringup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Feb 2012 15:04:57 -0800
From:	Colin Cross <ccross@...roid.com>
To:	Peter De Schrijver <pdeschrijver@...dia.com>
Cc:	Olof Johansson <olof@...om.net>,
	Stephen Warren <swarren@...dia.com>,
	Russell King <linux@....linux.org.uk>,
	Gary King <gking@...dia.com>, Arnd Bergmann <arnd@...db.de>,
	linux-tegra@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 05/10] ARM: tegra: rework Tegra secondary CPU core bringup

On Thu, Feb 9, 2012 at 3:47 PM, Peter De Schrijver
<pdeschrijver@...dia.com> wrote:
> Prepare the Tegra secondary CPU core bringup code for other Tegra variants.
> The reset handler is also generalized to allow for future introduction of
> powersaving modes which turn off the CPU cores.
>
> Based on work by:
>
> Scott Williams <scwilliams@...dia.com>
> Chris Johnson <cwj@...dia.com>
> Colin Cross <ccross@...roid.com>
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@...dia.com>
> ---
<snip>

> diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S
> index b5349b2..7973f1c 100644
> --- a/arch/arm/mach-tegra/headsmp.S
> +++ b/arch/arm/mach-tegra/headsmp.S

<snip>

> @@ -47,15 +64,116 @@ ENTRY(v7_invalidate_l1)
>         mov     pc, lr
>  ENDPROC(v7_invalidate_l1)
>
> +
>  ENTRY(tegra_secondary_startup)
> -       msr     cpsr_fsxc, #0xd3
>         bl      v7_invalidate_l1
> -       mrc     p15, 0, r0, c0, c0, 5
> -        and    r0, r0, #15
> -        ldr     r1, =0x6000f100
> -        str     r0, [r1]
> -1:      ldr     r2, [r1]
> -        cmp     r0, r2
> -        beq     1b
> +       mov32   r0, 0xC5ACCE55
> +       mcr     p14, 0, r0, c7, c12, 6

One minor nit, you should comment that this is enabling coresight.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/