linux-kernel - Re: [PATCH] HID: wacom: fix proximity tool release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Feb 2012 14:25:59 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Przemo Firszt <przemo@...szt.eu>
Cc:	aris@...hat.com, pinglinux@...il.com,
	linuxwacom-devel@...ts.sourceforge.net,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: wacom: fix proximity tool release

On Sun, 19 Feb 2012, Przemo Firszt wrote:

> Don't zero the current tool before reporting its release to the input
> subsystem.
> 
> Signed-off-by: Aristeu Rozanski <aris@...hat.com>
> Tested-by: Przemo Firszt <przemo@...szt.eu>
> ---
>  drivers/hid/hid-wacom.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> index 0621047..696b907 100644
> --- a/drivers/hid/hid-wacom.c
> +++ b/drivers/hid/hid-wacom.c
> @@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata,
>  
>  	switch (data[1]) {
>  	case 0x80: /* Out of proximity report */
> -		wdata->tool = 0;
>  		input_report_key(input, BTN_TOUCH, 0);
>  		input_report_abs(input, ABS_PRESSURE, 0);
>  		input_report_key(input, wdata->tool, 0);
> +		wdata->tool = 0;
>  		input_sync(input);
>  		break;
>  	case 0xC2: /* Tool report */

I have put this into my upstream-fixes branch. I think this should go into 
3.3 still.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/