linux-kernel - RE: [PATCH] checkpatch: Add some --strict coding style checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Feb 2012 10:46:14 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Joe Perches <joe@...ches.com>,
	David Miller <davem@...emloft.net>,
	Andy Whitcroft <apw@...dowen.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	andrei.emeltchenko.news@...il.com, linville@...driver.com,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH] checkpatch: Add some --strict coding style checks

On Wed, 2012-02-22 at 09:35 +0000, David Laight wrote:
> > 	if (!(func_a(x) &&
> > 		func_b(y)))
> > 		baz();
> 
> Gah - that is horrid for the 'preferred style'.
> A quick glance at the code puts both the func_b()
> and baz() calls as inside the if.

You forgot to read/quote the rest of Allan's email:

> Assuming my stupid mailer will screw up the indentation above, the 'a'
> in addr in the first example is meant to be immediately below the 'n'
> in nr, and the two 'f's in func_* are meant to be vertically lined up
> in the second example.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/