linux-kernel - Re: [PATCH v2 12/19] ARM: at91/rtc-at91sam9: each SoC can select the RTT device to use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Feb 2012 19:02:38 +0100
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-kernel@...r.kernel.org, rmallon@...il.com
Subject: Re: [PATCH v2 12/19] ARM: at91/rtc-at91sam9: each SoC can select
 the RTT device to use

On 17:25 Wed 22 Feb     , Arnd Bergmann wrote:
> On Wednesday 22 February 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > But if you change the rtc driver to always bind to the existing
> > > "at91_rtt" platform_device and fail the probe() function for the
> > > case that you are on at91sam9263 probing the non-RTC device,
> > > you should get the exact same result without any extra code
> > > in the per-soc files.
> >
> > agreed but as on at91sam9263 you have 2 RTTs so you can have 2 drivers at the
> > same time that use the RTT. So we can not do this except if we set the second
> > RTT to an other device name.
> 
> Let me rephrase what I meant then:
> 
> The first driver should in its probe function do:
> 
> 	if (pdev->id != CONFIG_RTC_DRV_AT91SAM9_RTT)
> 		return -ENODEV;
> 
> while the other driver does
> 
> 	if (pdev->id == CONFIG_RTC_DRV_AT91SAM9_RTT)
> 		return -ENODEV;
> 
> This way, each driver binds to one device but not the other.
> It should even work with an unmodified second driver, as long
> as you guarantee that it's loaded after the first one.
> 
> Any reason why this won't work?
just one other issue I need to pass the GPBR ressource to the RTC driver only

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/