lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Feb 2012 15:03:46 +0100 From: Roland Stigge <stigge@...com.de> To: Wolfram Sang <w.sang@...gutronix.de> CC: Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, kevin.wells@....com, Alan Stern <stern@...land.harvard.edu> Subject: Re: [PATCH v2] USB: Support for LPC32xx SoC On 25/02/12 04:51, Wolfram Sang wrote: >> Unfortunately, the way that ohci handles the abstraction between >> the various implementations is backwards, it would be much easier >> if the main driver was following that model to start with. > > ... exactly for that reason I didn't suggest it. Looking at other > ohci-sources (e.g. ohci-omap.c), machine_is_* seems to be the > consistent use-case. OK, considering this, I for now used machine_is_*() to get rid of the #ifdefs. Using platform_device_id.driver_data as Arnd suggested is also a good idea, and switching to it will be easy when it is due. Thanks in advance, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists