linux-kernel - Re: [PATCH 4/4] PCI: acpihp user __pci_remove_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Feb 2012 12:43:41 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] PCI: acpihp user __pci_remove_bus_device instead

On Mon, Feb 27, 2012 at 12:19 PM, Jesse Barnes <jbarnes@...tuousgeek.org> wrote:
> On Sat, 25 Feb 2012 13:54:23 -0800
> Yinghai Lu <yinghai@...nel.org> wrote:
>
>> pci_stop_bus_device get called before in the same loop.
>>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>>
>> ---
>>  drivers/pci/hotplug/acpiphp_glue.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: linux-2.6/drivers/pci/hotplug/acpiphp_glue.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/pci/hotplug/acpiphp_glue.c
>> +++ linux-2.6/drivers/pci/hotplug/acpiphp_glue.c
>> @@ -910,7 +910,7 @@ static int disable_device(struct acpiphp
>>                               disable_bridges(pdev->subordinate);
>>                               pci_disable_device(pdev);
>>                       }
>> -                     pci_stop_and_remove_bus_device(pdev);
>> +                     __pci_remove_bus_device(pdev);
>>                       pci_dev_put(pdev);
>>               }
>>       }
>>
>
> Ok applied these.  How about another that converts in-tree users to
> pci_remove_bus_device and marks the __ version deprecated though?

thanks.

now the only user for  __pci_remove_bus_device is acpiphp

it will call stop bus devices at first, and then disable all bridges
and then call __pci_remove_bus_device.

not sure why it need  to disable all bridges.

     Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/