lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Feb 2012 16:02:31 -0800 From: Kevin Hilman <khilman@...com> To: Tarun Kanti DebBarma <tarun.kanti@...com> Cc: <linux-omap@...r.kernel.org>, <grant.likely@...retlab.ca>, <tony@...mide.com>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 4/6] gpio/omap: get rid of retrigger variable in gpio_irq_handler Tarun Kanti DebBarma <tarun.kanti@...com> writes: > This local variable is just assigned zero and then OR'ed > with isr. It does not appear to serve any purpose and so > removing it. > > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@...com> Looks like the use of this was removed when I moved things over to using the generic IRQ framework, but I didn't fully clean up. Can you update the changelog to something along the lines of: "commit 672e302e3c (ARM: OMAP: use edge/level handlers from generic IRQ framework) removed retrigger support in favor of using generic IRQ framework. This patch cleans up some unused remnants of that removal. Thanks, Kevin > --- > drivers/gpio/gpio-omap.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index b62e861..3dd4b3a 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -623,7 +623,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) > u32 isr; > unsigned int gpio_irq, gpio_index; > struct gpio_bank *bank; > - u32 retrigger = 0; > int unmasked = 0; > struct irq_chip *chip = irq_desc_get_chip(desc); > > @@ -660,8 +659,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) > chained_irq_exit(chip, desc); > } > > - isr |= retrigger; > - retrigger = 0; > if (!isr) > break; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists