linux-kernel - Re: [patch] Adding Secure Deletion to UBIFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Feb 2012 19:09:32 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Joel Reardon <joel@...mbassador.com>
Cc:	linux-mtd@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] Adding Secure Deletion to UBIFS

On Thu, 2012-02-23 at 15:59 +0100, Joel Reardon wrote:
> >
> > Could you make a separate patch which adds new on-flash format and make
> > sure that new ubifs binaries can mount the old formats and work with
> > them. And that old ubifs binaries gracefully reject the new format.
> >
> 
> This patch provides a new version of two on-flash data structures for 
> UBIFS:

Similarly - wrapped patch and git am wont' apply it, sorry.

> ubifs_branch and ubifs_data_node have been grown by 8 bytes to include a 
> 64-bit reference
> to a key position, which is needed by a proposed ubifs secure deletion 
> addition. This patch is generated
> against linux-3.2.1.

Please, use linux-ubifs tree instead:
git://git.infradead.org/linux-ubifs.git

It has the newest stuff.

> Because both data structures use C99 flexible arrays, it is not possible 
> to add the new field as
> the last member of the structure.

>  Thus, it was added one before last, the 
> last was renamed, and in a
> handful of places where it was used, a macro accessor is used to get the 
> version-correct position.

Hmm, we can make it to be key[UBIFS_SK_LEN] instead, if it helps.

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)