linux-kernel - Re: [PATCH] Staging: asus_oled: fix checkpatch.pl issue in asus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Feb 2012 19:46:32 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Oliver N. Baumann" <oliver.n.baumann@...glemail.com>
Cc:	sjakub@...il.com, pq@....fi, baumanno@....ifi.lmu.de,
	kernel@...obrien.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: asus_oled: fix checkpatch.pl issue in
 asus_oled.c

On Wed, Feb 29, 2012 at 04:34:51AM +0100, Oliver N. Baumann wrote:
> From: "Oliver N. Baumann" <baumanno@....ifi.lmu.de>
> 
> This is a patch to asus_oled.c that fixes a parenthesis issue detected by checkpatch.pl tool
> Signed-off-by: Oliver N. Baumann <baumanno@....ifi.lmu.de>

You need a blank line between the changelog text and the signed-off-by
line.

Also, please wrap your changelog entry at 72 columns.

But most of all:

> ---
>  drivers/staging/asus_oled/asus_oled.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 1df9586..b77f225 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -44,9 +44,9 @@
>  
>  #define ASUS_OLED_ERROR			"Asus OLED Display Error: "
>  
> -#define ASUS_OLED_STATIC		's'
> -#define ASUS_OLED_ROLL			'r'
> -#define ASUS_OLED_FLASH			'f'
> +#define ASUS_OLED_STATIC		('s')
> +#define ASUS_OLED_ROLL			('r')
> +#define ASUS_OLED_FLASH			('f')

That's not a valid change, checkpatch is being stupid here, please use
your judgement.  This patch changes nothing, go bug the checkpatch
people to fix their tool.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/