linux-kernel - Re: .. anybody know of any filesystems that depend on the exact VFS 'namehash' implementation?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Mar 2012 02:11:19 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: .. anybody know of any filesystems that depend on the exact VFS 'namehash' implementation?

On Thu, Mar 01, 2012 at 05:01:52PM -0800, Linus Torvalds wrote:
> On Thu, Mar 1, 2012 at 4:46 PM, Andi Kleen <andi@...stfloor.org> wrote:
> >
> > There should be generally better modern general hash algorithms around,
> > like murmur, cityhash or snoopy. Perhaps even the fnv we have in tree,
> > but it's somewhat dated by know.
> >
> > They all have larger code, but if it's really that hot it would be worth
> > it.
> 
> The quality of our hash function really doesn't seem to be the issue.

With better I meant mainly faster in cycles.

e.g. CityHash claims upto ~6 bytes/cycle. That's extreme and may need
the SSE versions, but there are non SSE variants e.g. in spooky that are 
somewhat competive.

Are you anywhere near that with your hash function?

Partly they get that from unrolling, but there are also lots of other tricks.

Also BTW if we had better hash functions (in mixing) we could do smaller
hash tables.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/