linux-kernel - Re: [patch] block, sx8: fix pointer math issue getting fw version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 03 Mar 2012 12:08:13 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Jeff Garzik <jgarzik@...ox.com>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] block, sx8: fix pointer math issue getting fw version

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2012-03-03 09:04, Dan Carpenter wrote:
> On Sat, Mar 03, 2012 at 08:00:28AM +0100, Jens Axboe wrote:
>> On 2012-03-03 07:58, Jens Axboe wrote:
>>> On 2012-03-02 20:00, Dan Carpenter wrote:
>>>> "mem" is type u8.  We need parenthesis here or it screws up the pointer
>>>> math probably leading to an oops.
>>>
>>> Applied, thanks Dan. I have marked it stable, too.
>>
>> Hmm wait Dan, seems to me that u8 pointer math should be equiv to char *
>> pointer math and hence it'd work just fine. Are you sure this is a bug?
> 
> It's the cast on the line before is what breaks it.  We need the
> parentheses so we add first then cast the result.

Ah indeed, missed that. Thanks!

- -- 
Jens Axboe

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJPUfuYAAoJEPfTWPspceCm05AQAKfdxDDY2roFrTcOE5u0wKgL
UHXWmliwZAZLKbX939KdXHtnIhT3ylymRlRGAevGvp76GkjjRD1uaXywa3RPCG50
Ri3lOfUmXwQj5GJSmreFApvErMd2hKKTV3ARMtspd5HsAoABNHq+lrhXMsW90/hT
fa4IPjvKXP64FKKXmfr/MQ8d1bAVcYwvkfZsps2KS8Uj8EUr42AZt6bKMa0EOxxs
swgc3lQ2cwV+BmdjHTApkhH9lTzlot9bchPXYcPGDfWAtFO/MdrZ6ZNsR0Ak3LAN
0OOATReL5uupRgiHiHEJtym2jLSKc0RfJnU5qpgp5S9+Qbc5/j2Lt6M2yHysnTsW
POprT18pOm7lIPhdOCcSy55gW+UxVIWbqAr/5KuZNa1fAZxtghpPRQUOjkJhCdZV
vaFgoQCwDKZ5bjfWZ3NJxY5Di87M9JKyYrgh1XmmLInRqC4iBi5IdLdi54TmMJBo
pqLTFnDy1NaCf4E4xQqxuRTKcJyHt8QToMb2infP2Mz++jGZpygkiCUtIZwiDmq/
/J8MS9y2pNJDIZn71pyBIEQkgSXjerLqc5gEbUsszXo5w22r/VtR3PzVWGIK59Wq
RXhShLaLD7fPVpnlIVcoivv7O9EDXaEwFlqRI4mt68PGndmFcqWLFeV/8mbHP5ce
VZg3X+JY9CNxL4xvqGhb
=ORht
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/