| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 04 Mar 2012 08:19:30 -0600 From: James Bottomley <James.Bottomley@...senPartnership.com> To: "K. Y. Srinivasan" <kys@...rosoft.com> Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org, devel@...uxdriverproject.org, ohering@...e.com, hch@...radead.org, linux-scsi@...r.kernel.org, Haiyang Zhang <haiyangz@...rosoft.com> Subject: Re: [PATCH 1/1] Drivers: scsi: storvsc: Don't pass ATA_16 command to the host On Fri, 2012-03-02 at 12:49 -0800, K. Y. Srinivasan wrote: > Windows hosts don't handle the ATA_16 command; don't pass it to the host. What do you mean by this? Most SCSI devices don't handle ATA_16 because it's only useful if the device is actually an ATA device behind a bridge. As a general rule, you shouldn't filter in the driver commands you think the host won't want to see, you should let the host reply with an error code. You should *only* filter commands that cause an actual bug in the host. Is the latter the case for this command (if so that needs to be explained)? > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com> This signoff chain doesn't make sense, since you're sending me the patch and apparently you authored it. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists