linux-kernel - Re: [PATCH] bitops: Add missing parentheses to new get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 Mar 2012 15:58:26 +0000
From:	David Howells <dhowells@...hat.com>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>, Arnd Bergmann <arnd@...db.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] bitops: Add missing parentheses to new get_order macro

Joerg Roedel <joerg.roedel@....com> wrote:

> The new get_order macro introcuded in commit
> 
> 	d66acc39c7cee323733c8503b9de1821a56dff7e
> 
> does not use parentheses around all uses of the parameter n.
> This causes new compile warnings, for example in the
> amd_iommu_init.c function:
> 
> drivers/iommu/amd_iommu_init.c:561:6: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]
> drivers/iommu/amd_iommu_init.c:561:6: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]
> 
> Fix those warnings by adding the missing parentheses.
> 
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: H. Peter Anvin <hpa@...or.com>
> Signed-off-by: Joerg Roedel <joerg.roedel@....com>

Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/