linux-kernel - Re: [PATCH 1/2] core dump: drop VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed,  7 Mar 2012 13:41:04 -0800 (PST)
From:	Roland McGrath <roland@...k.frob.com>
To:	Jason Baron <jbaron@...hat.com>
Cc:	akpm@...ux-foundation.org, avi@...hat.com,
	linux-kernel@...r.kernel.org, qemu-devel@...gnu.org,
	cmetcalf@...era.com
Subject: Re: [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

A few of the vDSO VM_ALWAYSDUMP cases have a comment about the core dump.
(It looks like they were all copied from my original comment in
arch/x86/vdso/vdso32-setup.c.)  So those should be removed where they are.
(You removed some of them, but not all.)  You should put that comment into
always_dump_vma.

get_gate_vma is always defined quite trivially, and is also the most
logically obvious case, so I would test it first.

It sounds like the Tile special case is unnecessary, so just
arch_vma_name(vma) != NULL is an adequate test.  Please give it
a clear comment about why that test makes sense, i.e. because all
extant uses are for a vDSO or something similar.

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/