linux-kernel - Re: [PATCH RESEND v3] USB: Support for LPC32xx SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 08 Mar 2012 23:01:00 +0100
From:	Roland Stigge <stigge@...com.de>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, w.sang@...gutronix.de,
	kevin.wells@....com, linux-arm-kernel@...ts.infradead.org,
	arnd@...db.de
Subject: Re: [PATCH RESEND v3] USB: Support for LPC32xx SoC

On 08/03/12 22:11, Greg Kroah-Hartman wrote:
>> -	pnx4008_unset_usb_bits();
>> +	if (machine_is_pnx4008())
>> +		pnx4008_unset_usb_bits();
> 
> How come some of these pnx4008_* functions you have wrapped in
> machine_is_pnx4008(), but not all of them?
> 
> Actually, why don't those functions do that kind of checking themselves,
> without having to do this before you call them each time?

Good idea, I moved the machine dependent execution of the bits()
functions into the functions.

The dependency is only in the bits functions because those are done via
interfaces not available on LPC. The other pnx4008 functions seem to be
mostly compatible.

Thanks for your notes!

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/