linux-kernel - Re: [PATCH] x86: use enum instead of literals for trap values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 11 Mar 2012 10:52:12 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andy Lutomirski <luto@....edu>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mike Frysinger <vapier@...too.org>,
	Borislav Petkov <borislav.petkov@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] x86: use enum instead of literals for trap values

On Fri, Mar 09, 2012 at 08:30:49AM -0800, Kees Cook wrote:
> >> +enum {
> >> +     INTR_DIV_BY_ZERO = 0,   /*  0 */
> >> +     INTR_DEBUG,             /*  1 */
> >> +     INTR_NMI,               /*  2 */
> >> +     INTR_BREAKPOINT,        /*  3 */
> >> +     INTR_OVERFLOW,          /*  4 */
> >> +     INTR_BOUNDS_CHECK,      /*  5 */
> >> +     INTR_INVALID_OP,        /*  6 */
> >> +     INTR_NO_DEV,            /*  7 */
> >> +     INTR_DBL_FAULT,         /*  8 */
> >> +     INTR_SEG_OVERRUN,       /*  9 */
> >> +     INTR_INVALID_TSS,       /* 10 */
> >> +     INTR_NO_SEG,            /* 11 */
> >> +     INTR_STACK_FAULT,       /* 12 */
> >> +     INTR_GPF,               /* 13 */
> >> +     INTR_PAGE_FAULT,        /* 14 */
> >> +     INTR_SPURIOUS,          /* 15 */
> >> +     INTR_COPROCESSOR,       /* 16 */
> >> +     INTR_ALIGNMENT,         /* 17 */
> >> +     INTR_MCE,               /* 18 */
> >> +     INTR_SIMD_COPROCESSOR,  /* 19 */
> >> +     INTR_IRET = 32,         /* 32 */
> >> +};

This should be written like INTR_DEBUG=1 etc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/