linux-kernel - Re: mfd: mc13xxx: add I2C support, V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Mar 2012 12:50:18 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Marc Reilly <marc@...esign.com.au>
Cc:	sameo@...ux.intel.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	u.kleine-koenig@...gutronix.de,
	spi-devel-general@...ts.sourceforge.net, oskar@...ra.com
Subject: Re: mfd: mc13xxx: add I2C support, V2

> The only issue from V1 [0] not addressed is the use of regmap - mainly, I don't
> have the time. I accept that this is a lame excuse but hope that use of regmap 
> can come later if it is required.

I really appreciate the effort, yet I fear that this is a show stopper. It gets
open coded what regmap is trying to abstract, adding complexity to the driver
instead of (probably) reducing it. We could also get caching basically for
free, if this is desired. I think the regmap approach should have been tried
before we go custom. sound/soc/codecs/ad193x.c might give an impression how
regmap spi/i2c in one driver could look like.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)