lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Mar 2012 07:17:02 +0100 From: Richard Cochran <richardcochran@...il.com> To: Takahiro Shimizu <tshimizu818@...il.com> Cc: jeffrey.t.kirsher@...el.com, davem@...emloft.net, lucas.demarchi@...fusion.mobi, mirq-linux@...e.qmqm.pl, paul.gortmaker@...driver.com, jdmason@...zu.us, john.stultz@...aro.org, arnd@...db.de, khc@...waw.pl, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com Subject: Re: [PATCH RE-SUBMIT 2/2] net/pch_gbe: supports eg20t ptp clock On Mon, Mar 12, 2012 at 09:35:44AM +0900, Takahiro Shimizu wrote: > Hello Richard, > > Thank you for the comment. > > > + if ((sk_run_filter(skb, ptp_filter) != PTP_CLASS_V2_IPV4) && > > > + (sk_run_filter(skb, ptp_filter) != PTP_CLASS_V1_IPV4)) { > > > > No, just run the filter once and test the result twice. > > > > Also, doesn't the timestamping unit work with IPv6 and L2? If so, > > don't restrict the driver to IPv4. > > > > > According to the EG20T spec, it support IPv6 too. But I did not any test > about IPv6 now. > Do you mean I don't restrict anything here? No, what I mean is that you only accept PTP_CLASS_V1_IPV4 or PTP_CLASS_V2_IPV4. You should accept any packet type supported by the hardware. If someone tries to use your driver with PTPv2 over UDPv6, for example, then the filter will return PTP_CLASS_V2_IPV6, and the match will fail. It will also fail for PTPv2 L2 and PTPv2 L2/VLAN. It does not make sense to me to limit the driver in this way. Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists