linux-kernel - Re: [PATCH] dma: imx-dma: Fix build by including <linux/module.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2012 09:53:40 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	linux-kernel@...r.kernel.org, kernel@...gutronix.de,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] dma: imx-dma: Fix build by including <linux/module.h>

On Thu, 2012-03-08 at 18:26 -0300, Fabio Estevam wrote:
> commit 13ae246 (includecheck: delete any duplicate instances of module.) removed
> a duplicated module.h inclusion from imx-dma.c.
> 
> ,and commit 865d9438 (drivers/dma: linux/module.h included twice) did the same.
> 
> Let one linux/module.h be included so that it can be built again.
> 
> This fix the following error:
> 
> C      drivers/dma/imx-dma.o
> drivers/dma/imx-dma.c:658: error: expected declaration specifiers or '...' before string constant
> drivers/dma/imx-dma.c:658: warning: data definition has no type or storage class
> drivers/dma/imx-dma.c:658: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/dma/imx-dma.c:658: warning: function declaration isn't a prototype
> drivers/dma/imx-dma.c:659: error: expected declaration specifiers or '...' before string constant
> drivers/dma/imx-dma.c:659: warning: data definition has no type or storage class
> drivers/dma/imx-dma.c:659: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/dma/imx-dma.c:659: warning: function declaration isn't a prototype
> drivers/dma/imx-dma.c:660: error: expected declaration specifiers or '...' before string constant
> drivers/dma/imx-dma.c:660: warning: data definition has no type or storage class
> drivers/dma/imx-dma.c:660: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/dma/imx-dma.c:660: warning: function declaration isn't a prototype
I reverted the commit 865d9438 (drivers/dma: linux/module.h included
twice) afetr it was reported on linux-next. You should not see any
errors now. 
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>  drivers/dma/imx-dma.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index ca78fca..7be8d1f 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -25,6 +25,7 @@
>  #include <linux/slab.h>
>  #include <linux/platform_device.h>
>  #include <linux/dmaengine.h>
> +#include <linux/module.h>
>  
>  #include <asm/irq.h>
>  #include <mach/dma-v1.h>


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/