lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Mar 2012 05:05:25 +0400 From: Anton Vorontsov <anton.vorontsov@...aro.org> To: Arun Murthy <arun.murthy@...ricsson.com> Cc: dwmw2@...radead.org, linux-kernel@...r.kernel.org, karl.komierowski@...ricsson.com, johan.palsson@...ricsson.com, linus.walleij@...aro.org Subject: [PATCH 6/6] ab8500: Turn unneeded global symbols into local ones The patch fixes the following sparse warning: drivers/power/ab8500_charger.c:1619:6: warning: symbol 'ab8500_charger_detect_usb_type_work' was not declared. Should it be static? drivers/power/abx500_chargalg.c:1709:24: warning: symbol 'abx500_chargalg_sysfs_ops' was not declared. Should it be static? drivers/power/ab8500_fg.c:2328:24: warning: symbol 'ab8500_fg_sysfs_ops' was not declared. Should it be static? Signed-off-by: Anton Vorontsov <anton.vorontsov@...aro.org> --- drivers/power/ab8500_charger.c | 2 +- drivers/power/ab8500_fg.c | 2 +- drivers/power/abx500_chargalg.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/ab8500_charger.c b/drivers/power/ab8500_charger.c index a7217d6..e2b4acc 100644 --- a/drivers/power/ab8500_charger.c +++ b/drivers/power/ab8500_charger.c @@ -1616,7 +1616,7 @@ static void ab8500_charger_ac_work(struct work_struct *work) * * Detect the type of USB plugged */ -void ab8500_charger_detect_usb_type_work(struct work_struct *work) +static void ab8500_charger_detect_usb_type_work(struct work_struct *work) { int ret; diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c index 0441f9d..eaf149e 100644 --- a/drivers/power/ab8500_fg.c +++ b/drivers/power/ab8500_fg.c @@ -2325,7 +2325,7 @@ ab8500_fg_store(struct kobject *kobj, struct attribute *attr, const char *buf, return entry->store(di, buf, count); } -const struct sysfs_ops ab8500_fg_sysfs_ops = { +static const struct sysfs_ops ab8500_fg_sysfs_ops = { .show = ab8500_fg_show, .store = ab8500_fg_store, }; diff --git a/drivers/power/abx500_chargalg.c b/drivers/power/abx500_chargalg.c index fbb6a1f..804b88c 100644 --- a/drivers/power/abx500_chargalg.c +++ b/drivers/power/abx500_chargalg.c @@ -1706,7 +1706,7 @@ static struct attribute *abx500_chargalg_chg[] = { NULL }; -const struct sysfs_ops abx500_chargalg_sysfs_ops = { +static const struct sysfs_ops abx500_chargalg_sysfs_ops = { .store = abx500_chargalg_sysfs_charger, }; -- 1.7.9 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists